[Bug 796875] rtsp-client: always allocate both IPV4 and IPV6 sockets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796875

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Mathieu Duponchelle from comment #6)
> (In reply to Sebastian Dröge (slomo) from comment #5)
> > Review of attachment 373192 [details] [review] [review]:
> > 
> > ::: gst/rtsp-server/rtsp-client.c
> > @@ +1880,3 @@
> > +
> > +    if (!gst_rtsp_stream_allocate_udp_sockets (ctx->stream,
> > G_SOCKET_FAMILY_IPV6, ct,
> > +            use_client_settings) && family == G_SOCKET_FAMILY_IPV6)
> > 
> > This still fails if allocating one of the two ports fails in the case where
> > the pool only contains one kind of addresses. That seems wrong
> > 
> 
> This fails configuring the client transport if we couldn't set it up for the
> requested family, but that is the current behaviour too, are you saying the
> current behaviour is wrong wrt that as well?

Oh I missed that additional condition. No it's fine I guess

> > Also you still have the problem you're fixing here with multicast now as
> > currently there is only one multicast sink. You at least have to add one for
> > both families.
> 
> I'm not sure I get what you mean, for udp the udp sinks can have both IPV6
> and IPV4 , it simply needs to be done before the sinks are started, are you
> saying this is not the case for multicast?

I guess that's irrelevant and part of the other bugs, so let's ignore that here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.