[Bug 796900] avdec: loses the last (num_cores + 1) frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796900

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373230|none                        |reviewed
             status|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 373230:
 --> (https://bugzilla.gnome.org/review?bug=796900&attachment=373230)

::: ext/libav/gstavviddec.c
@@ +1723,3 @@
       got_frame = gst_ffmpegviddec_frame (ffmpegdec, NULL, &ret);
     } while (got_frame && ret == GST_FLOW_OK);
+    avcodec_flush_buffers (ffmpegdec->context);

Why do you flush here now?

@@ +1731,3 @@
+send_packet_failed:
+  GST_WARNING_OBJECT (ffmpegdec, "send packet failed, could not drain
decoder");
+  goto done;

Shouldn't it report an error here indeed?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.