[Bug 796900] avdec: loses the last (num_cores + 1) frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796900

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Thibault Saunier from comment #4)
> Review of attachment 373230 [details] [review]:
> 
> ::: ext/libav/gstavviddec.c
> @@ +1723,3 @@
>        got_frame = gst_ffmpegviddec_frame (ffmpegdec, NULL, &ret);
>      } while (got_frame && ret == GST_FLOW_OK);
> +    avcodec_flush_buffers (ffmpegdec->context);
> 
> Why do you flush here now?

Because that was missing, the call to flush_buffers makes it so the decoder is
ready to decode again.

> 
> @@ +1731,3 @@
> +send_packet_failed:
> +  GST_WARNING_OBJECT (ffmpegdec, "send packet failed, could not drain
> decoder");
> +  goto done;
> 
> Shouldn't it report an error here indeed?


No, as you know we don't want to error out at the first problem in the decoders
/ encoders, it should be translated to GST_AUDIO_DECODER_ERROR along with the
rest of the error handling code, but that's a separate issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.