[Bug 796480] qtdemux: Forward upstream time-format segment without mapping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796480

--- Comment #4 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 372506:
 --> (https://bugzilla.gnome.org/review?bug=796480&attachment=372506)

::: gst/isomp4/qtdemux.c
@@ +6908,3 @@
+            /* Forward upstream driven time format segment, and also do not
try
+             * to map edit list with the upstream time format segment.
+             * It's upstream element's role (the origin of time format
segment)

It's not upstream element's role to map edit lists at all. A proper
implementation should never emit unmapped segments downstream. But there are
bugs that prevent that from working, so if it makes the tests pass again, even
if it's wrong, I'm fine with it -- ideally as a temporary solution.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.