[Bug 796480] qtdemux: Forward upstream time-format segment without mapping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796480

--- Comment #5 from Seungha Yang <pudding8757 at gmail.com> ---
(In reply to Alicia Boya García from comment #4)
> Review of attachment 372506 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +6908,3 @@
> +            /* Forward upstream driven time format segment, and also do not
> try
> +             * to map edit list with the upstream time format segment.
> +             * It's upstream element's role (the origin of time format
> segment)
> 
> It's not upstream element's role to map edit lists at all. A proper
> implementation should never emit unmapped segments downstream. But there are
> bugs that prevent that from working, so if it makes the tests pass again,
> even if it's wrong, I'm fine with it -- ideally as a temporary solution.

IMHO, time format segment should not be modified by demuxer since there must be 
 some reason (period change and etc) why upstream element set it. This can
break multi-period use case also. As far as I know, edit list in dash stream is
restricted, but if there are, dashdemux should parse edit list (dashdemux is
already parsing some atoms such as moof, sidx) using isoff parser.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.