[Bug 796544] qtdemux: Add comment about qtdemux->segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796544

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---


(In reply to Nicolas Dufresne (ndufresne) from comment #6)
> Review of attachment 372607 [details] [review]:
> 
> Looks like a pretty good comment to me.
> 
> ::: gst/isomp4/qtdemux.h
> @@ +119,3 @@
> +  /* Configured playback region.
> +   *
> +   * segment.format is always GST_FORMAT_TIME.
> 
> I know Thibault said otherwise, but reading basesrc code, FORMAT_BYTES seems
> to be used there. And FORMAT_PERCENT is implemented also in there, so I have
> my doubt about deprecation. For the demuxer output format, I think always
> TIME is perfect.

Where did I say otherwise? The format should always be TIME afaict.

(In reply to Alicia Boya García from comment #3)
> Review of attachment 372606 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.h
> @@ -119,1 +119,8 @@
> -  /* configured playback region */
> +  /* Configured playback region.
> +   *
> +   * segment.time is never read.
> ... 5 more ...
> 
> What do you mean?

Stating that we do not read it in that comment doesn't bring much fmpov, that
is basically what I meant. I remember it is set in the dash case, not sure we
care at all but I would prefer to avoid to add comments that can outdate.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.