[Bug 796544] qtdemux: Add comment about qtdemux->segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796544

--- Comment #8 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
(In reply to Thibault Saunier from comment #7)
> 
> (In reply to Nicolas Dufresne (ndufresne) from comment #6)
> > Review of attachment 372607 [details] [review] [review]:
> > 
> > Looks like a pretty good comment to me.
> > 
> > ::: gst/isomp4/qtdemux.h
> > @@ +119,3 @@
> > +  /* Configured playback region.
> > +   *
> > +   * segment.format is always GST_FORMAT_TIME.
> > 
> > I know Thibault said otherwise, but reading basesrc code, FORMAT_BYTES seems
> > to be used there. And FORMAT_PERCENT is implemented also in there, so I have
> > my doubt about deprecation. For the demuxer output format, I think always
> > TIME is perfect.
> 
> Where did I say otherwise? The format should always be TIME afaict.

In reference to comment #2, "Sounds like somethings that might (likely?) get
obsoleted." I don't think it's a candidate for that no.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.