[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793441

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372692|none                        |reviewed
             status|                            |

--- Comment #52 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372692:
 --> (https://bugzilla.gnome.org/review?bug=793441&attachment=372692)

As mentioned above, this is actually not enough but a good start. We need to
potentially use multiple multicast sockets unfortunately

::: gst/rtsp-server/rtsp-stream.c
@@ +1627,3 @@
+  client->rtp_port = rtp_port;
+  client->add_count = 1;
+  priv->mcast_clients = g_list_append (priv->mcast_clients, client);

g_list_append() is O(n). Either prepend() or use a GQueue or similar

@@ +1654,3 @@
+
+  if (!check_address_and_ports (destination, rtp_port, rtcp_port, TRUE))
+    goto invalid_address;

Why do you need to check here? There will be nothing to remove if it's invalid
:)

@@ +3338,3 @@
+
+    if ((g_strcmp0 (cli->address, tr->destination) == 0) &&
+        (cli->rtp_port == tr->port.min))

What is this function actually checking, what is it good for?

@@ +4397,3 @@
+ */
+gchar *
+gst_rtsp_stream_get_multicast_client_addresses (GstRTSPStream * stream)

What is this actually used for, and why a comma-separated list in a string?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.