[Bug 796716] encoding: Add an ih264enc to unify H264 video encoder APIs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 28 19:55:55 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796716

--- Comment #4 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 372868:
 --> (https://bugzilla.gnome.org/review?bug=796716&attachment=372868)

::: gst-libs/gst/video/gsth264encoderinterface.h
@@ +40,3 @@
+ * GstH264EncoderInterfaceInterface:
+ * @parent: parent interface type.
+ * @set_bitrate: Set bitrate (in bits per second)

You probably want to document the expected behaviour more specifically what
should the behaviour be at the bounds, does a bitrate of 0 mean "automatic"
like some encoders?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list