[Bug 796716] encoding: Add an ih264enc to unify H264 video encoder APIs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796716

--- Comment #5 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Mathieu Duponchelle from comment #4)
> Review of attachment 372868 [details] [review]:
> 
> ::: gst-libs/gst/video/gsth264encoderinterface.h
> @@ +40,3 @@
> + * GstH264EncoderInterfaceInterface:
> + * @parent: parent interface type.
> + * @set_bitrate: Set bitrate (in bits per second)
> 
> You probably want to document the expected behaviour more specifically what
> should the behaviour be at the bounds, does a bitrate of 0 mean "automatic"
> like some encoders?

Right, although the meaning and the way it is used should be exclusively
handled by the wrapper (0 is not acceptable at that point). I think we will
want an extra property to represent that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.