[Bug 791724] nvdec: update for CUDA 9

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 5 08:13:49 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=791724

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369266|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 369266:
 --> (https://bugzilla.gnome.org/review?bug=791724&attachment=369266)

Thanks for the patch! Does the same also apply to nvenc?

::: sys/nvdec/dynlink_cuda.c
@@ +28,3 @@
+#include <stdio.h>
+#include <dynlink_cuda.h>
+#include <GL/freeglut.h>

Why glut?

@@ +51,3 @@
+tcuGraphicsGLRegisterImage *cuGraphicsGLRegisterImage;
+
+static char CudaLibName[] = "libcuda.so";

Previously the plugin also worked at least on Windows

@@ +81,3 @@
+  }
+  //Init
+  _cuInit = (tcuInit *) dlsym (lib, "cuInit");

Would be better to use gmodule for these

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list