[Bug 791724] nvdec: update for CUDA 9

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791724

--- Comment #3 from Snir <ssheribe at redhat.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 369266 [details] [review]:
> 
> Thanks for the patch! Does the same also apply to nvenc?
> 

Probably not, It uses only symbols needed by nvdec, could be expanded for nvenc 

> ::: sys/nvdec/dynlink_cuda.c
> @@ +28,3 @@
> +#include <stdio.h>
> +#include <dynlink_cuda.h>
> +#include <GL/freeglut.h>
> 
> Why glut?
> 

It was just for the GLenum GLuint but probably can just typedef these instead

> @@ +51,3 @@
> +tcuGraphicsGLRegisterImage *cuGraphicsGLRegisterImage;
> +
> +static char CudaLibName[] = "libcuda.so";
> 
> Previously the plugin also worked at least on Windows
> 

Missed that..

> @@ +81,3 @@
> +  }
> +  //Init
> +  _cuInit = (tcuInit *) dlsym (lib, "cuInit");
> 
> Would be better to use gmodule for these

True.

Thanks! I hope to have some time to fix these issues soon.

Snir.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.