[Bug 794591] gst-play-1.0 leaves stdin in non-blocking mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794591

Antonio Ospite <ao2 at ao2.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369997|0                           |1
        is obsolete|                            |

--- Comment #5 from Antonio Ospite <ao2 at ao2.it> ---
Created attachment 370020
  --> https://bugzilla.gnome.org/attachment.cgi?id=370020&action=edit
tools: play: fix leaving STDIN in non-blocking mode after exit

gst-play-1.0 sets STDIN to non-blocking mode to have the input
characters read as soon as they arrive.

However, when gst_play_kb_set_key_handler() gets called from
restore_terminal() it forgets to restore the STDIN blocking status.

This can result in broken behavior for cli command executed in the same
terminal after gst-play-1.0 exited.

It turns out that putting STDIN in non-blocking mode is not even the
proper way to achieve the desired effect, instead VMIN and VTIME in
struct termios should be set to 0.

Let's do that, and don't mess with the STDIN blocking mode now that it's
not necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.