[Bug 794591] gst-play-1.0 leaves stdin in non-blocking mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794591

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.14.1

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks!

commit cfc1be0d61e7c4c79afbc16873cd3bc38fa55f79
Author: Antonio Ospite <ao2 at ao2.it>
Date:   Thu Mar 22 11:12:20 2018 +0100

    tools: play: fix leaving STDIN in non-blocking mode after exit

    gst-play-1.0 sets STDIN to non-blocking mode to have the input
    characters read as soon as they arrive.

    However, when gst_play_kb_set_key_handler() gets called from
    restore_terminal() it forgets to restore the STDIN blocking status.

    This can result in broken behavior for cli command executed in the same
    terminal after gst-play-1.0 exited.

    It turns out that putting STDIN in non-blocking mode is not even the
    proper way to achieve the desired effect, instead VMIN and VTIME in
    struct termios should be set to 0.

    Let's do that, and don't mess with the STDIN blocking mode now that it's
    not necessary.

    https://bugzilla.gnome.org/show_bug.cgi?id=794591

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.