[Bug 794822] rtsp-server: add API to enable retransmission requests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794822

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370315|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370315:
 --> (https://bugzilla.gnome.org/review?bug=794822&attachment=370315)

Looks mostly good to me

::: gst/rtsp-server/rtsp-media.c
@@ +163,3 @@
 #define DEFAULT_STOP_ON_DISCONNECT TRUE

+#define DEFAULT_DO_RETRANSMISSION FALSE

Also needs a GObject property for consistency I guess

::: gst/rtsp-server/rtsp-stream.c
@@ +2369,3 @@
+  stream->priv->rtxreceive = gst_element_factory_make ("rtprtxreceive", NULL);
+  pt_map = gst_structure_new_empty ("application/x-rtp-pt-map");
+  g_hash_table_foreach (stream->priv->ptmap, (GHFunc) add_rtx_pt, pt_map);

This might have to be updated whenever the ptmap changes, or do we just not
support that?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.