[Bug 794822] rtsp-server: add API to enable retransmission requests

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 30 08:13:22 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794822

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370315:
 --> (https://bugzilla.gnome.org/review?bug=794822&attachment=370315)

::: gst/rtsp-server/rtsp-media.c
@@ +3076,3 @@
+  g_mutex_unlock (&priv->lock);
+
+  return gst_rtsp_stream_request_aux_receiver (stream, sessid);

Maybe should handle the case when the stream is not found (return NULL)? And we
find the stream by comparing the sessid with its index, but then we still pass
the sessid into this function? The stream already knows about it :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list