[Bug 794822] rtsp-server: add API to enable retransmission requests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794822

--- Comment #6 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 370315 [details] [review]:
> 
> ::: gst/rtsp-server/rtsp-media.c
> @@ +3076,3 @@
> +  g_mutex_unlock (&priv->lock);
> +
> +  return gst_rtsp_stream_request_aux_receiver (stream, sessid);
> 
> Maybe should handle the case when the stream is not found (return NULL)?

Indeed, that is also a bug in the function that was copied
(request_aux_sender), I'll fix both

> And
> we find the stream by comparing the sessid with its index, but then we still
> pass the sessid into this function? The stream already knows about it :)

this also was copied from stream_request_aux_sender, as this is "API" we cannot
change that prototype, and I'd rather have both functions share the same
prototype?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.