[Bug 794822] rtsp-server: add API to enable retransmission requests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794822

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 370315 [details] [review]:
> 
> Looks mostly good to me
> 
> ::: gst/rtsp-server/rtsp-media.c
> @@ +163,3 @@
>  #define DEFAULT_STOP_ON_DISCONNECT TRUE
>  
> +#define DEFAULT_DO_RETRANSMISSION FALSE
> 
> Also needs a GObject property for consistency I guess

rtx-time doesn't expose a property, I can add one but then one will also be
needed in media-factory

> 
> ::: gst/rtsp-server/rtsp-stream.c
> @@ +2369,3 @@
> +  stream->priv->rtxreceive = gst_element_factory_make ("rtprtxreceive",
> NULL);
> +  pt_map = gst_structure_new_empty ("application/x-rtp-pt-map");
> +  g_hash_table_foreach (stream->priv->ptmap, (GHFunc) add_rtx_pt, pt_map);
> 
> This might have to be updated whenever the ptmap changes, or do we just not
> support that?

I'm not sure whether a new ANNOUNCE in the RECORD case is supported by
rtsp-server, but I'll update stream_set_pt_map anyway :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.