[Bug 795424] qtdemux: Add MSE-style flush

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795424

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371339|reviewed                    |needs-work
             status|                            |

--- Comment #13 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 371339:
 --> (https://bugzilla.gnome.org/review?bug=795424&attachment=371339)

::: gst/isomp4/qtdemux.c
@@ +1526,3 @@
   gst_event_set_seqnum (event, seqnum);
+  qtdemux->offset_seek_seqnum = seqnum;
+  qtdemux->propagate_flush = TRUE;

This is the only place where it is set to TRUE, in the user flushing case, this
might very well still be set to FALSE.

I think it should be set to TRUE in _init, and then maybe be reset in the  code
path in FLUSH_STOP where it was set to FALSE.

--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 371339:
 --> (https://bugzilla.gnome.org/review?bug=795424&attachment=371339)

::: gst/isomp4/qtdemux.c
@@ +1526,3 @@
   gst_event_set_seqnum (event, seqnum);
+  qtdemux->offset_seek_seqnum = seqnum;
+  qtdemux->propagate_flush = TRUE;

This is the only place where it is set to TRUE, in the user flushing case, this
might very well still be set to FALSE.

I think it should be set to TRUE in _init, and then maybe be reset in the  code
path in FLUSH_STOP where it was set to FALSE.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.