[Bug 795424] qtdemux: Add MSE-style flush

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 17 22:12:07 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795424

--- Comment #15 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> Yes I agree with Thibault here. The tricky part will be about keeping the
> sample tables or not. After a flush, the demuxer should probably check if
> the first buffer contains a moov/moof somehow for your case, and for the
> seek case (and also adaptivedemux keyframe-only mode) check if we're at a
> known sample boundary.

This patch takes a simple approach where the sample table is flushed whenever
we get a flush from the "app/user" it might not be always correct indeed, but I
guess it won't break (people should not flush without knowing what they do :)),
do you think it would?

> The demuxer should not depend on the flush coming from a seek or not, and it
> should also properly handle disconts in the stream (as signaled by the
> corresponding buffer flag).

Well, if you get a flushing seek, and transmit a flushing seek upstream, you
can rely on the fact that you will get flushes. Or what you meant was related
to making a distinction between a flush coming from a seek or coming from
something else? I think it is not so unusual in practice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list