[Bug 751605] audio: Add proper support for non-interleaved / planar audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751605

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372125|none                        |reviewed
             status|                            |

--- Comment #30 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372125:
 --> (https://bugzilla.gnome.org/review?bug=751605&attachment=372125)

Looks good to go IMHO, except for some minor bikeshedding below

::: gst-libs/gst/audio/audio-buffer.h
@@ +52,3 @@
+  GstAudioInfo info;
+
+  gsize        samples;

Seems inconsistent with below. Maybe should be called n_samples?

@@ +55,3 @@
+
+  gint         n_planes;
+  gsize        plane_size;

Or plane_stride?

::: gst-libs/gst/audio/gstaudiometa.c
@@ +416,3 @@
+                "areas to overlap! offsets: %" G_GSIZE_FORMAT " (%d), %"
+                G_GSIZE_FORMAT " (%d) with plane size %" G_GSIZE_FORMAT,
+                offsets[i], i, offsets[j], j, plane_size);

This limitation should be documented (if not happened already)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.