[Bug 751605] audio: Add proper support for non-interleaved / planar audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751605

--- Comment #31 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
(In reply to Sebastian Dröge (slomo) from comment #30)
> Review of attachment 372125 [details] [review]:
> 
> Looks good to go IMHO, except for some minor bikeshedding below
> 
> ::: gst-libs/gst/audio/audio-buffer.h
> @@ +52,3 @@
> +  GstAudioInfo info;
> +
> +  gsize        samples;
> 
> Seems inconsistent with below. Maybe should be called n_samples?

Agreed.

> @@ +55,3 @@
> +
> +  gint         n_planes;
> +  gsize        plane_size;
> 
> Or plane_stride?

Hmm, it's called a plane_stride in GstVideoFrame, but it somehow feels wrong
here. By convention we usually call "size" the valid amount of information and
"stride" the step that you have to make to find the next valid object in
memory.

In this case plane_size is the amount of valid data. Doing planes[i] +
plane_size will NOT necessarily give you a pointer to the next plane.

> ::: gst-libs/gst/audio/gstaudiometa.c
> @@ +416,3 @@
> +                "areas to overlap! offsets: %" G_GSIZE_FORMAT " (%d), %"
> +                G_GSIZE_FORMAT " (%d) with plane size %" G_GSIZE_FORMAT,
> +                offsets[i], i, offsets[j], j, plane_size);
> 
> This limitation should be documented (if not happened already)

Ugh, I thought I documented it, but apparently I forgot. Will do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.