[Bug 796386] wasapi: add a new volume property and implement volume/mute using ISimpleAudioVolume

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796386

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372385|none                        |reviewed
             status|                            |

--- Comment #2 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 372385:
 --> (https://bugzilla.gnome.org/review?bug=796386&attachment=372385)

Thanks for working on this, it was on my TODO list. There's also
https://bugzilla.gnome.org/show_bug.cgi?id=793059 which you might be interested
in. :)

::: sys/wasapi/gstwasapisink.c
@@ +248,3 @@
+    IUnknown_Release (simple_audio_volume);
+    HR_FAILED_AND (hr, ISimpleAudioVolume::SetMute, return);
+  }

Shouldn't this short-circuit in exclusive mode?

@@ +257,3 @@
+  HRESULT hr;
+
+  /* FIXME: support exclusive mode */

Maybe this should be a GST_FIXME_OBJECT instead?

@@ +275,3 @@
+  float volume;
+
+  /* FIXME: support exclusive mode */

ditto.

@@ +302,3 @@
+    HR_FAILED_AND (hr, ISimpleAudioVolume::GetMute, goto err);
+    self->mute = mute;
+  }

Shouldn't this short-circuit in exclusive mode?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.