[Bug 796386] wasapi: add a new volume property and implement volume/mute using ISimpleAudioVolume

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796386

--- Comment #3 from Christoph Reiter (lazka) <reiter.christoph at gmail.com> ---
(In reply to Nirbheek Chauhan from comment #2)
> Review of attachment 372385 [details] [review]:
> 
> Thanks for working on this, it was on my TODO list. There's also
> https://bugzilla.gnome.org/show_bug.cgi?id=793059 which you might be
> interested in. :)

Do you happen to know if the wasapisink is worse in that area
(switching/removing devices) compared to directsoundsink?

> ::: sys/wasapi/gstwasapisink.c
> @@ +248,3 @@
> +    IUnknown_Release (simple_audio_volume);
> +    HR_FAILED_AND (hr, ISimpleAudioVolume::SetMute, return);
> +  }
> 
> Shouldn't this short-circuit in exclusive mode?

It still sets the volume so if the element would be restarted in shared mode
the volume would be restored to that set value, it just has no noticeable
effect in exclusive mode. But I can skip it if you want.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.