[Bug 797270] splitmuxsink: Subtract daily jam offset when day wraps around

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797270

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373886|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373886:
 --> (https://bugzilla.gnome.org/review?bug=797270&attachment=373886)

::: gst/multifile/gstsplitmuxsink.c
@@ +1184,3 @@
         splitmux->fragment_start_time;
+
+    if (cur_tc->config.flags | GST_VIDEO_TIME_CODE_FLAGS_DROP_FRAME &&

This needs parenthesis

@@ +1208,3 @@
+      next_max_tc_time -=
+          gst_util_uint64_scale (frames_of_daily_jam * GST_SECOND,
+          cur_tc->config.fps_d, cur_tc->config.fps_n);

Shouldn't this be part of some helper function that increments a timecode by a
specific amount?

Also wouldn't it be better to do all calculations without the daily jam only
based on the frame counter? And here you seem to be subtracting the 2 or 5
frames for every next timecode, not only when it wraps around a day?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.