[Bug 797270] splitmuxsink: Subtract daily jam offset when day wraps around

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797270

--- Comment #3 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Thanks, will update the patch later. Just a few comments for now:

(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 373886 [details] [review]:
> 
> ::: gst/multifile/gstsplitmuxsink.c
>
> Also wouldn't it be better to do all calculations without the daily jam only
> based on the frame counter?

It's not always possible. If you're not adding integer multiples of 10 minutes,
the amount of frames can depend on the start timecode.

> And here you seem to be subtracting the 2 or 5
> frames for every next timecode, not only when it wraps around a day?

It's under this:

  /* Add fragment_start_time, accounting for wraparound */
  if (target_tc_time >= cur_tc_time) {
[...]
  } else {

That's not visible in the diff though.

And you're totally right about the helper function,
gst_video_time_code_add_frames exists and I should have used it. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.