[Bug 795139] Various patches on rtpsession

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795139

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371999|none                        |reviewed
             status|                            |

--- Comment #72 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 371999:
 --> (https://bugzilla.gnome.org/review?bug=795139&attachment=371999)

This looks like the right thing to do indeed, it's surprising that we did
obtain the correct source but then proceeded to update the stats of the sender
of the packet. Also I don't think the comment in the commit is correct, afaict
we previously used the "SSRC of packet sender" obtained with
obtain_source(gst_rtcp_packet_rr_get_ssrc()), not with the ssrc of the last
report block.

::: gst/rtpmanager/rtpsession.c
@@ +2273,3 @@
        * the other sender to see if we are better or worse. */
       /* FIXME, need to keep track who the RB block is from */
+      rtp_source_process_rb (src, pinfo->ntpnstime, fractionlost,

Does that mean we can remove the FIXME right above? Also the comment will need
updating, as it says "we update the stats of the sender of the RTCP message.",
which will no longer be true

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.