[Bug 795139] Various patches on rtpsession

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795139

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372000|none                        |reviewed
             status|                            |

--- Comment #73 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 372000:
 --> (https://bugzilla.gnome.org/review?bug=795139&attachment=372000)

Only minor comments, this is OK to commit for me once these are addressed

::: gst/rtpmanager/rtpsession.c
@@ +612,3 @@
+      g_param_spec_uint ("stats-notify-min-interval",
+          "Stats notify minimum interval",
+          "Minimum interval between emitting notify signal for stats (in ms)",

between emissions of the notify signal rather?

::: tests/check/elements/rtpsession.c
@@ +1239,3 @@
+count_report_stats (GObject * object, GParamSpec * spec, gint * counter)
+{
+  (void) object;

Any reason not to use G_GNUC_UNUSED?

@@ +1297,3 @@
+
+  /* verify we have generated less than 3 stats for all these packets */
+  fail_unless (stats_callback_count < 3);

Can we not make a strict comparison here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.