[Bug 797299] x264enc: Print full option-string applied to x264_encoder in debug log ...
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Oct 18 11:07:04 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=797299
--- Comment #5 from Yeongjin Jeong <gingerbk247 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Comment on attachment 373954 [details] [review]
> [1/2] x264enc: Don't use hard-coded constant value in nal type check
>
> Looks good to me but please explain in the commit message what you do
> exactly, why and what it fixes. Definitely makes sense to not hardcode this
> though, it will just fall apart sooner or later if x264enc behaviour changes
> slightly.
Sorry, It is an obvious my mistake. I'll upload it again, including the commit
message.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list