[Bug 797299] x264enc: Print full option-string applied to x264_encoder in debug log ...

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797299

--- Comment #6 from Yeongjin Jeong <gingerbk247 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Comment on attachment 373955 [details] [review]
> [2/2] x264enc: Print full option-string applied to x264_encoder in debug log
> 
> While the idea is good, just assuming that every SEI contains this as a
> NUL-terminated string at offset 25 is not great. Can we detect the SEI type
> and add some safety guards for this?

I agree with this comment. I'll think about that and fix the patch. 

Thanks for the review :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.