[Bug 785684] rtspconnection: Add API for sending multiple messages at once, and for having the message body consist of multiple chunks of memory

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785684

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374029|none                        |needs-work
             status|                            |

--- Comment #40 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 374029:
 --> (https://bugzilla.gnome.org/review?bug=785684&attachment=374029)

Thanks! Please also describe in the commit message what exactly you're fixing
:)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +3881,3 @@
      * before */
+    for (int m = 0; m < k; m++) {
+      gst_memory_unmap (map_infos[m].memory, &map_infos[m]);

This is C99, please declare the variable elsewhere :)

@@ +3905,2 @@
         if (bytes_written >= 0) {
+          if (bytes_written >= (msg->data_size - msg->data_offset)) {

The parenthesis are not needed here

@@ +3909,3 @@
             /* all data of this message is sent, check body and otherwise
              * skip the whole message for next time */
+            bytes_written -= (msg->data_size - msg->data_offset);

and here

@@ +3920,3 @@
             }

+            if ((bytes_written + msg->body_offset) >= body_size) {

and here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.