[Bug 785684] rtspconnection: Add API for sending multiple messages at once, and for having the message body consist of multiple chunks of memory

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785684

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374030|none                        |needs-work
             status|                            |

--- Comment #41 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 374030:
 --> (https://bugzilla.gnome.org/review?bug=785684&attachment=374030)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +4446,3 @@
     g_source_set_callback (watch->writesrc,
+        (GSourceFunc) gst_rtsp_source_dispatch_write, g_source_ref (watch),
+        g_source_unref);

I think this creates a circular reference: The watch has a reference to the
writesrc, the writesrc now has a reference to the watch.

Better to use a GWeakRef here, or otherwise break the reference cycle.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.