[Bug 797338] dshowvideosrc: add device-index, add GstDeviceMonitor, and several fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797338

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374051|none                        |reviewed
             status|                            |

--- Comment #18 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 374051:
 --> (https://bugzilla.gnome.org/review?bug=797338&attachment=374051)

::: sys/dshowsrcwrapper/gstdshow.cpp
@@ +34,3 @@
 };

+

Accidental whitespace?

@@ +360,3 @@
+        gchar *friendly_name =
+            g_utf16_to_utf8 ((const gunichar2 *) varFriendlyName.bstrVal,
+            wcslen (varFriendlyName.bstrVal), NULL, NULL, NULL);

Maybe you want to refactor this into a utility function? I noticed that you
were repeating this a lot in various files. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.