[Bug 797338] dshowvideosrc: add device-index, add GstDeviceMonitor, and several fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797338

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374052|none                        |needs-work
             status|                            |

--- Comment #19 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 374052:
 --> (https://bugzilla.gnome.org/review?bug=797338&attachment=374052)

Looks good overall! Can be pushed once the copyright header is fixed.

::: sys/dshowsrcwrapper/dshowdeviceprovider.c
@@ +3,3 @@
+ *
+ * ksdeviceprovider.c: Kernel Streaming device probing and monitoring
+ *

Fix the author and the filename please.

@@ +56,3 @@
+
+  GST_DEBUG ("class init");
+

This is not needed.

::: sys/dshowsrcwrapper/dshowdeviceprovider.h
@@ +3,3 @@
+ *
+ * ksdeviceprovider.h: Kernel Streaming device probing and monitoring
+ *

Same.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.