[Bug 797145] avwait: Send dropping=true message after all streams stopped

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797145

--- Comment #5 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Thanks, please review again.

(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 373656 [details] [review]:
> 
> ::: gst/timecode/gstavwait.c
> @@ +931,3 @@
> +  }
> +  g_mutex_lock (&self->mutex);
> +  if ((self->must_send_end_message & 4) != 0) {
> 
> This should probably check 2 | 4?
> 
> @@ +1094,3 @@
>          self->ainfo.bpf);
> +    if (self->must_send_end_message >= 1) {
> +      send_element_message = TRUE;
> 
> This should probably be |= 4 with the flags? The boolean seems unnecessary

It is necessary because we unlock the mutex in the meantime. That may lead to a
race where the video chain might trigger the message with the next (dropped)
incoming video buffer, even though audio hasn't called gst_pad_push yet. Added
a comment to clarify this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.