[Bug 797145] avwait: Send dropping=true message after all streams stopped

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797145

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373672|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373672:
 --> (https://bugzilla.gnome.org/review?bug=797145&attachment=373672)

::: gst/timecode/gstavwait.c
@@ +880,3 @@
         /* We just stopped recording: synchronise the audio */
         self->audio_running_time_to_end_at = running_time;
+        self->must_send_end_message = END_MESSAGE_STREAM_ENDED;

Shouldn't this and above not be |= ? And what if audio (or video) ended long
ago already due to EOS, this does not seem to be handled

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.