[Bug 797174] rtsp-server: Receiver streams affect latency on the whole pipeline and cause poor performance in senders

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797174

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373702|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373702:
 --> (https://bugzilla.gnome.org/review?bug=797174&attachment=373702)

Only a very short review for now

::: gst/rtsp-server/Makefile.am
@@ +33,3 @@
     rtsp-sdp.c \
     rtsp-thread-pool.c \
+    rtsp-latency-bin.c \

Also has to be added to meson.build, and please don't install the header :)
Let's keep it private API for now.

::: gst/rtsp-server/rtsp-onvif-media.c
@@ +272,3 @@
+
+  gst_object_ref (backchannel_bin);
+  gst_bin_remove (GST_BIN (element), backchannel_bin);

This needs some comment. Why are you removing the elements, the additional ref,
etc.

It's a hack for the time being until there's a more generic solution in
collect_streams() :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.