[Bug 797174] rtsp-server: Receiver streams affect latency on the whole pipeline and cause poor performance in senders

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797174

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373702:
 --> (https://bugzilla.gnome.org/review?bug=797174&attachment=373702)

::: gst/rtsp-server/rtsp-latency-bin.c
@@ +196,3 @@
+
+  switch (GST_MESSAGE_TYPE (message)) {
+    case GST_MESSAGE_LATENCY:{

You should do the same in change_state() when going from PAUSED->PLAYING or
PLAYING->PLAYING. I know that it will fail for your use-case, but in other
cases there is never a LATENCY message and it will succeed during the state
change

@@ +215,3 @@
+      if (!gst_element_query (target_element, query)) {
+        GST_WARNING_OBJECT (bin, "latency query failed");
+        gst_object_unref (target_element);

You leak the query here

@@ +249,3 @@
+ */
+GstElement *
+gst_rtsp_latency_bin_new (void)

This would be nicer by just taking the internal bin/element as a constructor
parameter here. Then you don't need to work with the element-added signal, and
it won't work well for multiple elements anyway

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.