[Bug 793333] matroskademux: Allow Matroska headers to be read more than once

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793333

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373731|none                        |reviewed
             status|                            |

--- Comment #16 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 373731:
 --> (https://bugzilla.gnome.org/review?bug=793333&attachment=373731)

Makes sense to me.

::: gst/matroska/matroska-demux.c
@@ +651,3 @@
           GST_ERROR_OBJECT (demux, "Invalid TrackNumber 0");
           ret = GST_FLOW_ERROR;
           break;

Why can't you keep doing the unique check here?

@@ +1514,3 @@
+      break;
+
+    case GST_MATROSKA_TRACK_TYPE_COMPLEX:

just `default:` then?

@@ +3112,3 @@
+          if (gst_matroska_read_common_tracknumber_unique (&demux->common,
+                  track->num))
+            gst_matroska_demux_add_stream (demux, track);

Please add brackets around that if too

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.