[Bug 793333] matroskademux: Allow Matroska headers to be read more than once

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793333

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373732|none                        |needs-work
             status|                            |

--- Comment #18 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 373732:
 --> (https://bugzilla.gnome.org/review?bug=793333&attachment=373732)

Looks good otherwise.

::: gst/matroska/matroska-demux.c
@@ +3138,3 @@

+static GstFlowReturn
+gst_matroska_demux_reparse_tracks (GstMatroskaDemux * demux, GstEbmlRead *
ebml)

update_tracks?

@@ +3178,3 @@
+            gst_matroska_read_common_stream_from_num (&demux->common,
+            new_track->num);
+        g_assert (old_track_index != -1);

That should not be an assertion, if there is a mismatch the track might not be
found, and we should cleanly error out.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.