[gst-devel] [patch] ok to commit?

[steve at stevebaker.org]

I have no problems with this patch.

cheers

> 
> ok to commit this to gst-player? this uses the new
> gst_gconf_get_default_[audio/video]_sink functions to get sane 
defaults
> for an uninstalled player and gstreamer core. it makes gst-player 
work
> with uninstalled gst.
> 
> regards,
> 
> wingo.
> <br>
> 
> ? autoregen.sh
> ? gst-player-gconf.patch
> ? gstreamer-player-uninstalled.pc
> ? gstreamer-player.pc
> ? intltool-extract
> ? intltool-extract.in
> ? intltool-merge
> ? intltool-merge.in
> ? intltool-update
> ? intltool-update.in
> ? po/.intltool-merge-cache
> ? po/Makefile.in.in
> ? po/POTFILES
> ? po/nl.gmo
> ? po/no.gmo
> ? tests/gstcmdplay
> Index: libs/gst/player/gstmediaplay.c
> ===================================================================
> RCS file: /cvsroot/gstreamer/gst-
player/libs/gst/player/gstmediaplay.c,v
> retrieving revision 1.64
> diff -u -r1.64 gstmediaplay.c
> --- libs/gst/player/gstmediaplay.c	23 Sep 2002 16:16:30 -0000
	1.64
> +++ libs/gst/player/gstmediaplay.c	16 Oct 2002 19:47:46 -0000
> @@ -128,11 +128,11 @@
>  	g_return_if_fail(mplay->play != NULL);
>  
>  	/*audio_sink = gst_gconf_render_bin_from_key("osssink 
fragment=1572872");*/
> -	audio_sink = gst_gconf_render_bin_from_key
("default/audiosink");
> +	audio_sink = gst_gconf_get_default_audio_sink ();
>  	g_return_if_fail(GST_IS_ELEMENT(audio_sink));
>  	gst_play_set_audio_sink(mplay->play, audio_sink);
>  
> -	video_sink = gst_gconf_render_bin_from_key
("default/videosink");
> +	video_sink = gst_gconf_get_default_video_sink ();
>  	g_return_if_fail(GST_IS_ELEMENT(video_sink));
>  	gst_play_set_video_sink(mplay->play, video_sink);
>  
> 
> <br>

_______________________________________________________________________________E-Mail service provided by Pop3-Email.com