[gst-devel] Re: [gst-cvs] dschleef gstreamer: gstreamer/

[Thomas Vander Stichele]

Hi david,

beside missing the macro itself (adding it to the branch right now) this
might not be a good idea since we try to keep the branch compilable at
all times for gnome cvs builds.  Being on sf generates enough bad blood
as is :)

any chance i could revert this patch until the compiler problems are
fixed ?

(BTW, in general I am of course all for having this enabled, I don't
even know who had the idea to remove them from the branch in the first
place)

Thomas

On Tue, 2003-08-05 at 09:59, David Schleef wrote:
> CVS Root:       /cvsroot/gstreamer
> Module:         gstreamer
> Changes by:     dschleef
> Date:           Tue Aug 05 2003  00:59:35 PDT
> Branch:         BRANCH-GSTREAMER-0_6
> 
> Log message:
> Convert to using AS_COMPILER_FLAG() to test for flags, and REENABLE
> -Wall -Werror.  This causes a large number of compilation failures
> currently.
> 
> Modified files:
>     .               : configure.ac
> 
> Links:
> http://cvs.sf.net/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.205.2.2.2.18&r2=1.205.2.2.2.19
> 
> ====Begin Diffs====
> Index: configure.ac
> ===================================================================
> RCS file: /cvsroot/gstreamer/gstreamer/configure.ac,v
> retrieving revision 1.205.2.2.2.18
> retrieving revision 1.205.2.2.2.19
> diff -u -d -r1.205.2.2.2.18 -r1.205.2.2.2.19
> --- configure.ac	11 Jun 2003 22:18:40 -0000	1.205.2.2.2.18
> +++ configure.ac	5 Aug 2003 07:59:23 -0000	1.205.2.2.2.19
> @@ -36,19 +36,9 @@
>  AM_PROG_AS
>  AS="${CC}"
>  
> -dnl decide on error flags
> -AS_COMPILER(COMPILER)
> -if test "x$COMPILER" = "xforte"; then
> -  GST_ERROR=
> -else
> -  if test "x$GST_CVS"="xyes"; then
> -    GST_ERROR="-Wall -Werror"
> -  else
> -    GST_ERROR="-Wall"
> -  fi
> -fi
> -dnl fix these error flags first, then reintroduce them
> -GST_ERROR=
> +AS_COMPILER_FLAG(-Wall,GST_ERROR="$GST_ERROR -Wall",)
> +AS_COMPILER_FLAG(-Werror,GST_ERROR="$GST_ERROR -Werror",)
> +
>  
>  dnl We disable static building for development, for time savings
>  dnl *NOTE*: dnl this line before release, so release does static too
> @@ -365,17 +355,6 @@
>  if test "x$USE_DEBUG" = xyes; then
>     GST_INT_CFLAGS="$GST_INT_CFLAGS -g"
>  fi
> -
> -if test "x$USE_PROFILING" = xyes; then
> -dnl  CFLAGS="$CFLAGS -pg -fprofile-arcs"
> -  FOMIT_FRAME_POINTER=""
> -else
> -  FOMIT_FRAME_POINTER="-fomit-frame-pointer"
> -fi
> -
> -dnl
> -dnl AC_SUBST(FOMIT_FRAME_POINTER)
> -dnl
>  
>  dnl #############################
>  dnl # Set automake conditionals #
> 
> 
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
> _______________________________________________
> gstreamer-cvs-verbose mailing list
> gstreamer-cvs-verbose at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs-verbose

Dave/Dina : future TV today ! - http://davedina.apestaart.org/
<-*- thomas (dot) apestaart (dot) org -*->
Ooh child I'll meet you child
On the sunny side it's alright
<-*- thomas (at) apestaart (dot) org -*->
URGent, best radio on the net - 24/7 ! - http://urgent.rug.ac.be/