[gst-devel] Re: [gst-cvs] dschleef gst-plugins: gst-plugins/gst/videocrop/

[Ronald Bultje]

Hey Dave,

> Rewrote the core function.  Added some nice #defines that should
> probably go in gstvideo.h.  Fixes #118245.
[..]
> +#define GST_VIDEO_I420_SIZE(width,height) ((width)*(height) +
((width)/2)*((height)/2)*2)
> +
> +#define GST_VIDEO_I420_Y_OFFSET(width,height) (0)
> +#define GST_VIDEO_I420_U_OFFSET(width,height) ((width)*(height))
> +#define GST_VIDEO_I420_V_OFFSET(width,height) ((width)*(height) +
((width/2)*(height/2)))
> +
> +#define GST_VIDEO_I420_Y_ROWSTRIDE(width) (width)
> +#define GST_VIDEO_I420_U_ROWSTRIDE(width) ((width)/2)
> +#define GST_VIDEO_I420_V_ROWSTRIDE(width) ((width)/2)

Nah, they're format-specific. If you want this, then you'd need a function
(not a macro)
that takes a fourcc or a GstCaps as argument, but that'd add some overhead
so nobody
would use it...

If you think that's not so bad, then please go ahead. :).

Ronald