[gst-devel] Re: [gst-cvs] jesimon gst-plugins: gst-plugins/ext/flac/

[Thomas Vander Stichele]

Hey appoc,

Next time, could you please
a) file one complete patch for the issue you're fixing
b) attach the patch to the bugzilla report
c) request for it to be applied

It's very hard to keep the list of bugs fixed in sync when people commit
to STABLE without warning, in more than one commit, and without letting
it be known through bugzilla.

I'll close the bug now and add a not there.

Thanks
Thomas


On Sat, 2003-09-20 at 20:59, Jeremy SIMON wrote:
> CVS Root:       /cvsroot/gstreamer
> Module:         gst-plugins
> Changes by:     jesimon
> Date:           Sat Sep 20 2003  11:59:17 PDT
> Branch:         BRANCH-GSTREAMER-0_6
> 
> Log message:
> fix flac file detection (#121143)
> 
> Modified files:
>     ext/flac        : gstflac.c
> 
> Links:
> http://cvs.sf.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/ext/flac/gstflac.c.diff?r1=1.9.8.1&r2=1.9.8.2
> 
> ====Begin Diffs====
> Index: gstflac.c
> ===================================================================
> RCS file: /cvsroot/gstreamer/gst-plugins/ext/flac/gstflac.c,v
> retrieving revision 1.9.8.1
> retrieving revision 1.9.8.2
> diff -u -d -r1.9.8.1 -r1.9.8.2
> --- gstflac.c	7 Apr 2003 20:10:36 -0000	1.9.8.1
> +++ gstflac.c	20 Sep 2003 18:59:05 -0000	1.9.8.2
> @@ -70,12 +70,30 @@
>  static GstCaps* 
>  flac_type_find (GstBuffer *buf, gpointer private) 
>  {
> +  gint offset;
> +  guint8 *data;
> +  gint size;
>    guint32 head = GUINT32_FROM_BE (*((guint32 *)GST_BUFFER_DATA (buf)));
>  
> -  if (head  != 0x664C6143)
> -    return NULL;
> +  data = GST_BUFFER_DATA (buf);
> +  size = GST_BUFFER_SIZE (buf);
>  
> -  return gst_caps_new ("flac_type_find", "application/x-flac", NULL);
> +  if (head  == 0x664C6143)
> +    return gst_caps_new ("flac_type_find", "application/x-flac", NULL);
> +  else {
> +    /* checks for existance of flac identification header in case
> +     * there's an ID3 tag */
> +    for (offset = 0; offset < size-4; offset++) {
> +      if (data[offset]   == 'f' && 
> +          data[offset+1] == 'L' && 
> +          data[offset+2] == 'a' &&
> +          data[offset+3] == 'C' ) {
> +        return gst_caps_new ("flac_type_find", "application/x-flac", NULL);
> +      }
> +    }
> +  }
> +
> +  return NULL;
>  }
>  
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> gstreamer-cvs-verbose mailing list
> gstreamer-cvs-verbose at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs-verbose

Dave/Dina : future TV today ! - http://davedina.apestaart.org/
<-*- thomas (dot) apestaart (dot) org -*->
if you ever lay a finger on my left side
if you ever lay a finger on me I will open
<-*- thomas (at) apestaart (dot) org -*->
URGent, best radio on the net - 24/7 ! - http://urgent.rug.ac.be/