[gst-devel] Cleanups
Andy Wingo
wingo at pobox.com
Wed Feb 11 05:00:21 CET 2004
Yo,
I'm on janitor duty these days :) Anyone object to the following kinds
of cleanups? They're style fixes, not functional fixes.
* In API functions, don't check for NULL before checking for type.
That's to say, don't say:
g_return_if_fail (element != NULL);
g_return_if_fail (GST_IS_ELEMENT (element));
because GST_IS_ELEMENT checks for NULL already. This is more in line
with GTK.
* In docs, avoid redundancy. So not
@templ: the #GstPadTemplate to which the new pad should be able to
link.
but
@templ: a #GstPadTemplate.
The purpose of the function should in general be explained in the main
text, not in the parameter descriptions.
Also, are there objections to gst_object_[un]ref (gointer obj), like
g_object_[un]ref? Makes things a bit easier that way.
--
Andy Wingo <wingo at pobox.com>
More information about the gstreamer-devel
mailing list