[gst-devel] Cleanups

[David Schleef]

On Sat, Feb 07, 2004 at 02:43:44PM +0200, Andy Wingo wrote:
> I'm on janitor duty these days :) Anyone object to the following kinds
> of cleanups? They're style fixes, not functional fixes.
> 
> * In API functions, don't check for NULL before checking for type.
>   That's to say, don't say:
>   
>     g_return_if_fail (element != NULL);
>     g_return_if_fail (GST_IS_ELEMENT (element));
> 
>   because GST_IS_ELEMENT checks for NULL already. This is more in line 
>   with GTK.

Please do so.  This has bugged me for a long time.

Also, any style fixes that can be checked for by a regexp or a few
lines of perl, please put in gst-plugins/testsuite/gst-lint.  Or
just add a comment about what to check, and I'll add the code.




dave...