[gst-devel] Re: [gst-cvs] dolphy gst-plugins: gst-plugins/ gst-plugins/examples/gstplay/ gst-plugins/gst-libs/gst/play/ gst-plugins/gst-libs/gst/video/ gst-plugins/sys/ximage/ gst-plugins/sys/xvideo/ gst-plugins/sys/xvimage/

[David I. Lehn]

* Julien Moutte <dolphy at pdx.freedesktop.org> [2004-01-07T16:50:05-0500]:
>         * gst-libs/gst/play/gstplay.c: (gst_play_set_video_sink): Connecting tothe XOverlay size signal instead of GstVideoSink.
>         * gst-libs/gst/play/gstplay.h: Including the XOverlay interface to check        GST_IS_X_OVERLAY before signal connect.
>         * gst-libs/gst/video/gstvideosink.c: (gst_videosink_class_init):
>         Removing the have_video_size signal.
>         * gst-libs/gst/video/gstvideosink.h: Removing the have_video_size signal        and associated public method.
>         * sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents),
>         (gst_ximagesink_sinkconnect): Using XOverlay public method to fire size
>         signal.
>         * sys/xvideo/xvideosink.c: (gst_xvideosink_sinkconnect),
>         (gst_xvideosink_xwindow_new): Using XOverlay public method to fire size
>         signal.
>         * sys/xvimage/xvimagesink.c: (gst_xvimagesink_sinkconnect):
>         Using XOverlay public method to fire size signal.
> 

Is the goal in the end to have the play lib work with various
videosinks?  It would be nice to have common functionality in
GstVideoSink but looks like some of these changes are moving that off
into XOverlay or elsewhere rather than in shared code.  It would be nice
to be able to use SDL/AAlib/caca/DirectFB/GL/DirectX/etc as well once
they support appropriate interfaces and/or subclass GstVideoSink.

-dave