[gst-devel] Re: [gst-cvs] company gstreamer: gstreamer/ gstreamer/gst/

[Ronald Bultje]

Hi Benjamin,

On Sun, 2004-01-11 at 18:55, Benjamin Otte wrote:
> 2004-01-11  Benjamin Otte  <in7y118 at public.uni-hamburg.de>
> 	* gst/gstqueue.c: (gst_queue_init):
> 	  Use better defaults for when a queue should block. This
> 	  gets rid of jerky playback for quite a few files.
> 	  It takes more memory.
[..]
> -  queue->max_size.buffers	= 100;		/* max. 100 buffers */
> -  queue->max_size.bytes		= 1024 * 1024;	/* max. 1 MB */
> -  queue->max_size.time		= GST_SECOND;	/* max. 1 sec. */
> +  queue->max_size.buffers	= 250; /* high limit */
> +  queue->max_size.bytes		= 0; /* unlimited */
> +  queue->max_size.time		= 0; /* unlimited */

Log message is correct. ;). Can you please try to re-add the max. values
(possibly somewhat larger, my limits where quite strict indeed, e.g. 2/5
seconds and/or 5/10 MB) in there? I've added them to keep the amount of
memory down in non-ideal cases (think security etc., worst-case scenario
blabla). 250 raw full-PAL frames (think unsynced videotestsrc, RGB32)
can get up to 450 MB, which sounds less than ideal to me...

Thanks,

Ronald

-- 
Ronald Bultje <rbultje at ronald.bitfreak.net>
Linux Video/Multimedia developer