[gst-devel] Mastroska muxer 0.9 port

[Michal Benes]

Hi Thomas,

>  
>
>>	I have ported Matroska muxer to 0.9. The patch is available in bugzilla
>>as bug #318847
>>http://bugzilla.gnome.org/show_bug.cgi?id=318847
>>    
>>
>
>I glanced over it, looks good.  One request - we use only /* */ - style
>comments, could you update yours ?
>  
>
Sure, I have only overlooked some // commments in the original (these 
lines are marked as added in my patch only because 0.9 version of 
matroska was older than the 0.8 one). I will fix it.

>>	I have tried to follow all the guidelines (added many missing docs,
>>tested by valgrind, used the version from 0.8 branch, ...)
>>    
>>
>
>Excellent.  You say you tested with valgrind - I assume you ran it on
>gst-launch with some mkv files ? Any chance I can get you to add some
>unit tests to check for your muxer ?
>  
>
Of course, I am want to add proper unit tests. My test was C application 
with pipe
videotestsrc num-buffers=5 ! matroskamux ! filesink
and error handler connected. Is this enough? Where should the test be 
placed? Is it gst-plugins-good/testsuite/matroska? Is there some 
existing test I can use as reference?

Thanks
 
    Michal

PS.: I have ported only the muxer part because Tim is working on the 
demuxer.