[gst-devel] Mastroska muxer 0.9 port (unit testing)

Michal Benes michal.benes at xeris.cz
Tue Oct 25 09:57:54 CEST 2005


Hi Thomas,

I have started the work on the Matroska muxer unit tests. First of all,
let me say, I really appreciate that there is unit testing support in
GStreamer.

Now, I have some question about the testing: 

I was trying to use gst_check_setup_sink_pad. However, this fails since
matroska muxer references its source pad twice (one reference for
GstMatroskaMux and one for GstEbmlWrite). Does this mean that matroska
muxer behaves incorrectly or just that I should not use
gst_check_setup_sink_pad?

Also, I can not use gst_check_setup_src_pad since all muxer sink pads
are on request pad (and none of them is called "sink"). Could a new
function be implemented which takes the name of the sink pad as
parameters?

	Regards
		Michal

Thomas Vander Stichele píše v So 15. 10. 2005 v 13:00 +0200: 
> Hi,
> 
> > >
> > >Excellent.  You say you tested with valgrind - I assume you ran it on
> > >gst-launch with some mkv files ? Any chance I can get you to add some
> > >unit tests to check for your muxer ?
> > >  
> > >
> > Of course, I am want to add proper unit tests. My test was C application 
> > with pipe
> > videotestsrc num-buffers=5 ! matroskamux ! filesink
> > and error handler connected. Is this enough? Where should the test be 
> > placed? Is it gst-plugins-good/testsuite/matroska? Is there some 
> > existing test I can use as reference?
> 
> We have some pipeline checks in gstreamer/check/pipelines.
> For the matroska muxer, you could do something similar to
> gst-plugins-base/check/elements/vorbisdec.c
> 
> You construct test buffers, push them out on a pad into your muxer, and
> you test if your muxer reacts correctly - does it send the right error
> messages if you feed wrong data, does it handle eos, ...
> 
> Let me know if you need more info, testing element functionality is
> something we're still figuring out along the way :)
> 
> Thomas
> 
> 
> Dave/Dina : future TV today ! - http://www.davedina.org/
> <-*- thomas (dot) apestaart (dot) org -*->
> They say if you love somebody
> you have got to set them free
> but I would rather be locked to you
> than living in this pain and misery
> <-*- thomas (at) apestaart (dot) org -*->
> URGent, best radio on the net - 24/7 ! - http://urgent.fm/
> 
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Power Architecture Resource Center: Free content, downloads, discussions,
> and more. http://solutions.newsforge.com/ibmarch.tmpl
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel





More information about the gstreamer-devel mailing list